Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#27500 Replace deprecated constructs from Cron PHPUnit. #27577

Merged
merged 4 commits into from
Apr 15, 2020
Merged

magento/magento2#27500 Replace deprecated constructs from Cron PHPUnit. #27577

merged 4 commits into from
Apr 15, 2020

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

Part of PHPUnit 8 compatibility process for #27500

Related Pull Requests

Fixed Issues (if relevant)

  1. Unit Tests incompatible with PHPUnit 8 #27500

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev self-assigned this Apr 4, 2020
ihor-sviziev
ihor-sviziev requested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lbajsarowicz,

Could you update setUp and tearDown method return type to be :void?
In phpunit 8 I had fatal errors caused by not declared return type.

Could you also confirm that it works fine for you once you'll finish?

@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7296 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 15, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Kilo engcom-Kilo self-assigned this Apr 15, 2020
@okorshenko okorshenko changed the base branch from 2.4-develop to phpunit8 April 15, 2020 17:00
@okorshenko okorshenko merged commit 8948acb into magento:phpunit8 Apr 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team mentioned this pull request May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Cron Event: Global-Contribution-Day Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lbajsarowicz @magento-engcom-team @engcom-Alfa @ihor-sviziev @okorshenko @engcom-Kilo